Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClusterStorer for VectorHits #40363

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 19, 2022

PR description:

This PR is a follow-up to #40323 (comment).
If fixes the vectorHits based workflows in step-5 that we hitting an assertion after the merge of #40323.
I profit of this PR to add some workflows to test the vectorHits with singleMuon gun events (in order to have quicker turnaround in test times).

PR validation:

Run successfully:

 runTheMatrix.py --what upgrade -l 11634.0,20818.9,20834.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be part of backports of #40323

@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2022

type trk, bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2022

test parameters:

  • workflow = 20834.9, 20818.9
  • relvals_opt= -w upgrade

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40363/33461

  • This PR adds an extra 36KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DataFormats/TrackerRecHit2D (reconstruction)

@bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @VourMa, @abbiendi, @kpedro88, @Martin-Grunewald, @trtomei, @slomeo, @missirol, @makortel, @JanFSchulte, @jhgoh, @jdolen, @beaucero, @rovere, @VinInn, @gkasieczka, @hatakeyamak, @mmusich, @mtosi, @fabiocos, @ahinzmann, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2022

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e49cba/29694/summary.html
COMMIT: 9770ab7
CMSSW: CMSSW_13_0_X_2022-12-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40363/29694/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

  • 20834.020834.0_TTbar_14TeV+2026D88/step5_TTbar_14TeV+2026D88.log
  • 20834.7620834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33/step5_TTbar_14TeV+2026D88_HLTwDIGI75e33.log
  • 20834.7520834.75_TTbar_14TeV+2026D88_HLT75e33/step6_TTbar_14TeV+2026D88_HLT75e33.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

Pull request #40363 was updated. @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e49cba/29711/summary.html
COMMIT: 8195ef2
CMSSW: CMSSW_13_0_X_2022-12-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40363/29711/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555714
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction
No changes in comparisons.
Avoids an assert in an alcareco module.

@srimanob
Copy link
Contributor

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Dec 21, 2022

@cms-sw/pdmv-l2 do you have objections to the addition of the new workflows in commit fe0f886 ?

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants